GeezerVison is showing github.com — [3.15] gh-110128: Ignore a truncated final row in csv.Sniffer by Punisheroot · Pull Request #155037 · python/cpython
Conversation
Punisheroot
commented
Aug 1, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes #110128.
When a sample is truncated in the middle of its final row, the incomplete row can distort the character-frequency table used by _guess_delimiter() and cause Sniffer.sniff() to raise csv.Error.
This change excludes the final physical row from delimiter detection when the sample contains multiple rows and does not end with \r or \n. A single unterminated row remains usable.
The handling is intentionally kept within the existing _guess_delimiter() row preparation, making this a targeted maintenance-branch fix without changing the delimiter-detection algorithm. It mirrors the cut and len(rows) > 1 behavior of the rewritten Sniffer in Python 3.16. If maintainers would prefer the truncation handling at a different level, I’m happy to adjust the implementation.
Tests cover:
- single-row samples without a trailing newline;
- truncated samples with LF line endings;
- truncated samples with CRLF line endings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.