GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-110128: Ignore a truncated final row in csv.Sniffer by Punisheroot · Pull Request #155037 · python/cpython

Conversation

@Punisheroot

@Punisheroot Punisheroot commented Aug 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #110128.

When a sample is truncated in the middle of its final row, the incomplete row can distort the character-frequency table used by _guess_delimiter() and cause Sniffer.sniff() to raise csv.Error.

This change excludes the final physical row from delimiter detection when the sample contains multiple rows and does not end with \r or \n. A single unterminated row remains usable.

The handling is intentionally kept within the existing _guess_delimiter() row preparation, making this a targeted maintenance-branch fix without changing the delimiter-detection algorithm. It mirrors the cut and len(rows) > 1 behavior of the rewritten Sniffer in Python 3.16. If maintainers would prefer the truncation handling at a different level, I’m happy to adjust the implementation.

Tests cover:

  • single-row samples without a trailing newline;
  • truncated samples with LF line endings;
  • truncated samples with CRLF line endings.
  • Issue: CSV dialect sniffer gets wrong dialect (excel) when tab delimited csv file has been truncated #110128

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Punisheroot
[3.15] pythongh-110128: Ignore a truncated final row in csv.Sniffer
6975587
@bedevere-app bedevere-app Bot mentioned this pull request Aug 1, 2026
CSV dialect sniffer gets wrong dialect (excel) when tab delimited csv file has been truncated #110128
Closed
@Punisheroot
Punisheroot marked this pull request as ready for review August 1, 2026 18:06
@bedevere-app bedevere-app Bot added the awaiting review label Aug 1, 2026
@hugovk

hugovk commented Oct 29, 2026

Copy link
Copy Markdown
Member

Closing per #110128 (comment), thanks anyway!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Punisheroot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.