GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-155146: Do not depend on the exact number of allocations in test_class (GH-155150) by miss-islington · Pull Request #155157 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Try to fail every one of the first allocations and accept the first one which
fails in the code detaching the instance dictionary from the object, instead
of assuming that this is the first allocation after set_nomemory().

Run the test with the test.support.isolation.runInSubprocess() decorator
instead of executing it as a source string in a subprocess.
(cherry picked from commit 416c346)

Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: Claude Opus 5 (1M context) [email protected]

  • Issue: test_detach_materialized_dict_no_memory depends on the exact number of allocations #155146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @claude @miss-islington
pythongh-155146: Do not depend on the exact number of allocations in …
c6d77e8
…test_class (pythonGH-155150)

Try to fail every one of the first allocations and accept the first one which
fails in the code detaching the instance dictionary from the object, instead
of assuming that this is the first allocation after set_nomemory().

Run the test with the test.support.isolation.runInSubprocess() decorator
instead of executing it as a source string in a subprocess.
(cherry picked from commit 416c346)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Aug 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 4, 2026
test_detach_materialized_dict_no_memory depends on the exact number of allocations #155146
Closed
@bedevere-app bedevere-app Bot added the skip news label Aug 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 4, 2026
gh-155146: Do not depend on the exact number of allocations in test_class #155150
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Aug 4, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) August 4, 2026 08:51
@serhiy-storchaka
serhiy-storchaka merged commit 42b23da into python:3.13 Aug 4, 2026
43 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Aug 4, 2026
@miss-islington
miss-islington deleted the backport-416c346-3.13 branch August 4, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.