GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — gh-155245: Fix calendar failing to import when strftime rejects %OB by tekinertekin · Pull Request #155269 · python/cpython Conversation
|
| self.assertListEqual(list(calendar.month_abbr), | ||
| list(calendar.standalone_month_abbr)) | ||
|
|
||
| def test_standalone_month_fallback_when_specifier_rejected(self): |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This test isn't really relevant. It would be better to find a locale for which we could check the issue directly without mocking.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I consider a PR entirely written by an agent as not acceptable. The contribution should be credited to the agent in this case. We do not want to encourage users to use agents just to add a contribution line in their CV. We rather encourage human-driven contributions than automated ones. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
calendar module fails to import on Wine due to incomplete %OB error handling
There was an error while loading. Please reload this page.