GeezerVison is showing github.com — gh-155327: Guard SSLSocket chain methods after TLS teardown by tonghuaroot · Pull Request #155328 · python/cpython
Conversation
tonghuaroot
commented
Aug 7, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
SSLSocket.get_verified_chain() and get_unverified_chain() accessed
self._sslobj without the _checkClosed() / None guard used by every other
query method, so they raised AttributeError when called after the TLS layer
was torn down (for example after unwrap()). Add the guard and return an empty
list, matching the value these methods return for an empty chain.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
get_verified_chain() and get_unverified_chain() accessed self._sslobj without
the guard used by the other query methods, raising AttributeError after
unwrap(). Return an empty list instead.
|
This PR is stale because it has been open for 90 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
gpshead
Awaiting requested review from gpshead
gpshead is a code owner
picnixz
Awaiting requested review from picnixz
picnixz is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.