GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-154948: Fix `test_zipfile` failure when `SOURCE_DATE_EPOCH` is set (GH-155001) by StanFromIreland · Pull Request #155347 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Aug 7, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 82905dd)

  • Issue: test_zipfile can fail if SOURCE_DATE_EPOCH is set #154948

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
[3.15] pythongh-154948: Fix test_zipfile failure when `SOURCE_DATE_…
0905924 
…EPOCH` is set (pythonGH-155001)

(cherry picked from commit 82905dd)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Aug 7, 2026
test_zipfile can fail if SOURCE_DATE_EPOCH is set #154948
Closed
@bedevere-app bedevere-app Bot added the skip news label Aug 7, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 7, 2026
gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set #155001
Merged
@read-the-docs-community

read-the-docs-community Bot commented Aug 7, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33961774 | 📁 Comparing 0905924 against main (82905dd)

  🔍 Preview build  

294 files changed · + 1 added · ± 289 modified · - 4 deleted

+ Added

  • library/asyncio-policy.html

± Modified

  • index.html
  • py-modindex.html
  • c-api/apiabiversion.html
  • c-api/arg.html
  • c-api/coro.html
  • c-api/frame.html
  • c-api/gen.html
  • c-api/init_config.html
  • c-api/interp-lifecycle.html
  • c-api/module.html
  • and 279 more...

- Deleted

  • deprecations/pending-removal-in-3.21.html
  • library/tkinter.fontchooser.html
  • library/tkinter.systray.html
  • whatsnew/3.16.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland marked this pull request as ready for review August 7, 2026 15:05
@StanFromIreland
StanFromIreland requested review from FFY00, brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners August 7, 2026 15:05
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 7, 2026
@StanFromIreland
StanFromIreland requested a review from vstinner August 7, 2026 15:05
vstinner
vstinner approved these changes Aug 7, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This fix can wait for Python 3.15.1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 7, 2026
@StanFromIreland StanFromIreland assigned hugovk Aug 7, 2026
@StanFromIreland

StanFromIreland commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

This fix can wait for Python 3.15.1.

These are just changes to tests, so I assume they won't be an issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 7, 2026

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland assigned hugovk

As I wrote, I think that this change can wait for Python 3.15.1. No need to rush a fix in Python 3.15.0.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Aug 7, 2026

Copy link
Copy Markdown
Member

Tests can generally go in, they help improve the quality. 👍
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit c56ce5a into python:3.15 Aug 7, 2026
61 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 7, 2026
@StanFromIreland
StanFromIreland deleted the backport-82905dd-3.15 branch August 7, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @vstinner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.