GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-57336: Deprecate setting read-only attributes in xml.dom.minidom by serhiy-storchaka · Pull Request #155627 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 12, 2026

Copy link
Copy Markdown
Member

In the DOM model most node attributes are read-only, but in minidom only localName and length raised NoModificationAllowedErr. Setting the other ones silently left the node inconsistent with the document: for example, setting Attr.name renamed the attribute node, but the owner element still kept it under the old name.

Setting them now emits a DeprecationWarning. They are also documented as read-only.

  • Issue: xml.dom.Attr.name is not labeled as read-only #57336

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka requested a review from AA-Turner as a code owner August 12, 2026 14:05
@bedevere-app bedevere-app Bot mentioned this pull request Aug 12, 2026
xml.dom.Attr.name is not labeled as read-only #57336
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 12, 2026
@read-the-docs-community

read-the-docs-community Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34034643 | 📁 Comparing 94bd452 against main (b11e749)

  🔍 Preview build  

3 files changed
± library/xml.dom.html
± whatsnew/3.16.html
± whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
pythongh-57336: Deprecate setting read-only attributes in xml.dom.min…
94bd452 
…idom

In the DOM model most node attributes are read-only, but in minidom only
localName and length raised NoModificationAllowedErr.  Setting the other
ones silently left the node inconsistent with the document: for example,
setting Attr.name renamed the attribute node, but the owner element still
kept it under the old name.

Setting them now emits a DeprecationWarning.  They are also documented as
read-only.
@serhiy-storchaka
serhiy-storchaka force-pushed the gh-57336-deprecate-readonly-setters branch from cd1c027 to 94bd452 Compare August 12, 2026 15:04
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 12, 2026
gh-44871: Improve DOM Level 1 conformance of xml.dom.minidom #155641
Merged
@github-actions

github-actions Bot commented Nov 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.