GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-155752: Do not crash when GenericAlias parameters change during substitution (GH-155761) by miss-islington · Pull Request #155771 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 14, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

An alias argument can gain typing_subst after parameters has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments.
(cherry picked from commit c0006fa)

Co-authored-by: Darius Houle [email protected]

  • Issue: GenericAlias crashes when an argument gains __typing_subst__ after parameters are cached #155752

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dariushoule @miss-islington
pythongh-155752: Do not crash when GenericAlias parameters change dur…
202adf1
…ing substitution (pythonGH-155761)

An alias argument can gain __typing_subst__ after __parameters__ has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments.
(cherry picked from commit c0006fa)

Co-authored-by: Darius Houle <[email protected]>
@miss-islington
miss-islington requested review from AlexWaygood and JelleZijlstra as code owners August 14, 2026 05:14
@python-cla-bot

python-cla-bot Bot commented Aug 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot mentioned this pull request Aug 14, 2026
GenericAlias crashes when an argument gains __typing_subst__ after parameters are cached #155752
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 14, 2026
gh-155752: Do not crash when GenericAlias parameters change during substitution #155761
Merged
JelleZijlstra
JelleZijlstra approved these changes Aug 14, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 14, 2026
@terryjreedy

terryjreedy commented Sep 8, 2026

Copy link
Copy Markdown
Member

Approved by @JelleZijlstra who merged to main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy
terryjreedy merged commit 96964c8 into python:3.14 Sep 8, 2026
55 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 8, 2026
@miss-islington
miss-islington deleted the backport-c0006fa-3.14 branch September 8, 2026 02:01
@youknowdot youknowdot mentioned this pull request Oct 10, 2026
Reject stale GenericAlias parameters on Python 3.15 RustPython/RustPython#9069
Merged
@AnthonyRonning AnthonyRonning mentioned this pull request Nov 5, 2026
Agent: bring over the CPython worker runtime from #897 MaplePrivacyLabs/Maple#1409
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @JelleZijlstra @dariushoule
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.