GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-156402: Modernize annotation usage in libregrtest by ashm-dev · Pull Request #156403 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Aug 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Modernize annotation usage in libregrtest #156402

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting review label Aug 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 26, 2026
Modernize annotation usage in libregrtest #156402
Closed
@ashm-dev
Modernize annotation usage in libregrtest
a73656a
@ashm-dev
ashm-dev force-pushed the gh-156402 branch from 6401226 to a73656a Compare August 26, 2026 07:23
StanFromIreland
StanFromIreland reviewed Aug 26, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2026-08-26-10-06-54.gh-issue-156402.ouqfgaOZ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Aug 26, 2026
View reviewed changes
Comment thread Lib/test/libregrtest/results.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Aug 26, 2026

Copy link
Copy Markdown
Member

This is churn IMO.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Aug 26, 2026

Copy link
Copy Markdown
Member

This is churn IMO.

I think it's fine, considering we do use annotations here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Aug 26, 2026

Copy link
Copy Markdown
Member

It is still churn and can annoy backports because of indentation changes or suppresion of type: ignore.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev added 2 commits August 26, 2026 12:52
@ashm-dev
Remove unnecessary libregrtest NEWS entry
70ce71d
@ashm-dev
Move Element lazy import to stdlib import group
661fd50
@ashm-dev
ashm-dev requested a review from StanFromIreland August 26, 2026 09:54
JelleZijlstra
JelleZijlstra approved these changes Aug 26, 2026
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are pretty clearly positive changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 26, 2026
@JelleZijlstra JelleZijlstra added the skip news label Aug 26, 2026
StanFromIreland
StanFromIreland approved these changes Aug 26, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jelle.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@ashm-dev

ashm-dev commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra this has been "awaiting merge" since your approval on Aug 26. Could you merge it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
Merge branch 'main' into pythongh-156402
1ca3172
@ashm-dev
ashm-dev requested review from JelleZijlstra and StanFromIreland September 15, 2026 10:29
@JelleZijlstra
JelleZijlstra merged commit c39a329 into python:main Sep 17, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 17, 2026
@ashm-dev
ashm-dev deleted the gh-156402 branch September 17, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ashm-dev @picnixz @StanFromIreland @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.