GeezerVison is showing github.com — [3.13] gh-156896: Stop scrubbing tkinter submodules upon idlelib.run import (GH-156915) by serhiy-storchaka · Pull Request #156960 · python/cpython
Conversation
serhiy-storchaka
commented
Sep 4, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process.
This also includes the idlelib.run part of GH-152036, which was not backported and which the scrubbing code in main is based on: missing tkinter submodules are tolerated rather than assuming a fixed set. Lib/idlelib/run.py is now identical in main, 3.15, 3.14 and 3.13.
(cherry picked from commit e50d233)
Co-authored-by: Terry Jan Reedy [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…mport (python#156915)
Instead, invoke the scrubbing within run.main, which is called after
the import when starting the IDLE user process.
To manually test that scrub_tkinter_submodules
is called when proper, start (or restart) Shell, enter
`import tkinter; dir(tkinter), and check that that font,
messagebox, ttk, and the dialog modules are missing.
It is obvious from the code that the function is not otherwise
called. To test anyway, continue with `import tkinter.ttk;
import idlelib.run; tkinter.ttk` and check for proper output.
(cherry picked from commit e50d233)
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
terryjreedy
Awaiting requested review from terryjreedy
terryjreedy is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.