GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-156896: Stop scrubbing tkinter submodules upon idlelib.run import (GH-156915) by serhiy-storchaka · Pull Request #156960 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process.

This also includes the idlelib.run part of GH-152036, which was not backported and which the scrubbing code in main is based on: missing tkinter submodules are tolerated rather than assuming a fixed set. Lib/idlelib/run.py is now identical in main, 3.15, 3.14 and 3.13.

(cherry picked from commit e50d233)

Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: Importing idlelib.run deletes tkinter dialog submodules from sys.modules #156896

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@terryjreedy @serhiy-storchaka
pythongh-156896: Stop scrubbing tkinter submodules upon idlelib.run i…
4e7fe0b
…mport (python#156915)

Instead, invoke the scrubbing within run.main, which is called after
the import when starting the IDLE user process.

To manually test that scrub_tkinter_submodules
is called when proper, start (or restart) Shell, enter
`import tkinter; dir(tkinter), and check that that font,
messagebox, ttk, and the dialog modules are missing.

It is obvious from the code that the function is not otherwise
called.  To test anyway, continue with `import tkinter.ttk;
import idlelib.run; tkinter.ttk` and check for proper output.

(cherry picked from commit e50d233)
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy as a code owner September 4, 2026 20:38
@bedevere-app bedevere-app Bot mentioned this pull request Sep 4, 2026
Importing idlelib.run deletes tkinter dialog submodules from sys.modules #156896
Closed
@serhiy-storchaka serhiy-storchaka added the topic-IDLE label Sep 4, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 4, 2026
gh-156896: Stop scrubbing tkinker submodules upon idlelib.run import #156915
Merged
@terryjreedy
terryjreedy merged commit 5602f08 into python:3.13 Sep 4, 2026
45 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-IDLE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.