GeezerVison is showing github.com — gh-144446: Fix thread-safety of FrameLocalsProxy on executing frames by kumaraditya303 · Pull Request #156973 · python/cpython
Conversation
Synchronize FrameLocalsProxy accesses with the frame's owning thread: fast locals are accessed under the frame object's critical section, and with the world stopped when the frame may be executing on another thread.
Changes:
- Only the fast locals read and write run in the synchronized region. Key lookup (
__hash__ / __eq__) runs outside it, so no Python code is executed while the world is stopped.
- The extra locals dict is never touched by the running frame, so it does not need stop-the-world. It is fetched under the frame's critical section and used with the dict's own locking.
- The value replaced in a cell is decref'd after the region, since its destructor can run arbitrary code.
keys(), values(), items() and len() snapshot the fast locals in the region and hold the extra locals dict's critical section while iterating it.
PyFrame_GetVar is synchronized the same way.
Co-authored-by: Sam Gross [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…rames
Synchronize FrameLocalsProxy accesses with the frame's owning thread:
accessors run under the frame object's critical section and stop the
world when the frame is executing on another thread.
Co-authored-by: Sam Gross <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this back on your queue
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Matt meant to request changes.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mpage reacted with thumbs up emoji
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes!
@ambv, @mpage: please review the changes made to this pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|