GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-154511: Consolidate IDLE's mouse wheel handling in util (GH-156974) by miss-islington · Pull Request #157023 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Move wheel_event there from idlelib.tree and add x11_buttons(widget) and
bind_wheel(widget, func), used by the editor, the tree and test_sidebar.
wheel_event now reads the direction from the event, not the platform.

Move its test from test_tree, and test the fix_ functions of util too.
(cherry picked from commit 57594aa)

Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: Claude Opus 5 [email protected]

  • Issue: IDLE - Update mousewheel event handling #154511

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @claude @miss-islington
pythongh-154511: Consolidate IDLE's mouse wheel handling in util (pyt…
ce15f89
…honGH-156974)

Move wheel_event there from idlelib.tree and add x11_buttons(widget) and
bind_wheel(widget, func), used by the editor, the tree and test_sidebar.
wheel_event now reads the direction from the event, not the platform.

Move its test from test_tree, and test the fix_ functions of util too.
(cherry picked from commit 57594aa)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner September 6, 2026 06:15
@bedevere-app bedevere-app Bot mentioned this pull request Sep 6, 2026
IDLE - Update mousewheel event handling #154511
Open
@bedevere-app bedevere-app Bot added the awaiting review label Sep 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 6, 2026
gh-154511: Consolidate IDLE's mouse wheel handling in util #156974
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) September 6, 2026 06:16
@serhiy-storchaka @claude
pythongh-154511: Set the scaling with the Tcl command in test_fix_sca…
321518b
…ling

Misc.tk_scaling is new in 3.16, and fix_scaling itself calls "tk
scaling" here.

Co-Authored-By: Claude Opus 5 <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit 19693af into python:3.13 Sep 6, 2026
43 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Sep 6, 2026
@miss-islington
miss-islington deleted the backport-57594aa-3.13 branch September 6, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.