GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-156939: Fix xmlcharrefreplace() buffer overflow (GH-157109) by miss-islington · Pull Request #157233 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 9, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Write into a temporary buffer to not write the trailing NUL byte
into the writer. Previously, the NUL byte was written outsize
the writer buffer.
(cherry picked from commit 9398655)

Co-authored-by: Victor Stinner [email protected]

  • Issue: C API: Detect buffer overflow in PyBytesWriter #156939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-156939: Fix xmlcharrefreplace() buffer overflow (pythonGH-15…
e40dd22 
…7109)

Write into a temporary buffer to not write the trailing NUL byte
into the writer. Previously, the NUL byte was written outsize
the writer buffer.
(cherry picked from commit 9398655)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2026
C API: Detect buffer overflow in PyBytesWriter #156939
Closed
@bedevere-app bedevere-app Bot added awaiting review skip news labels Sep 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2026
gh-156939: Fix xmlcharrefreplace() buffer overflow #157109
Merged
@vstinner
vstinner enabled auto-merge (squash) September 9, 2026 19:19
@StanFromIreland
StanFromIreland disabled auto-merge September 10, 2026 20:08
@StanFromIreland

StanFromIreland commented Sep 10, 2026

Copy link
Copy Markdown
Member

@vstinner this is broken on older branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Replace _Py_MAX_UNICODE with MAX_UNICODE
4f7e933
@vstinner

vstinner commented Sep 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@StanFromIreland:

@vstinner this is broken on older branches.

Oh thanks for the ping, I didn't pay attention if this backport was merged or not.

Objects/unicodeobject.c:966:25: error: ‘_Py_MAX_UNICODE’ undeclared (first use in this function); did you mean ‘MAX_UNICODE’?

The compiler hint is correct, 3.14 uses MAX_UNICODE. I pushed a change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 5d1f8ae into python:3.14 Sep 14, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 14, 2026
@miss-islington
miss-islington deleted the backport-9398655-3.14 branch September 14, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @StanFromIreland @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.