GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-157495: Implement Py_MIN() and Py_MAX() using typeof() by vstinner · Pull Request #157496 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 14, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

If typeof() is available, implement Py_MIN(), Py_MAX() and Py_ABS() using typeof() and statement expression to only evaluate each argument once.

Test also these macros in test_cext and test_cppext to test different compiler flags and test the limited C API.

  • Issue: C API: Implement Py_MIN(), Py_MAX() and Py_ABS() macros using typeof() #157495

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-157495: Implement Py_MIN() and Py_MAX() using typeof()
21764e4 
If typeof() is available, implement Py_MIN(), Py_MAX() and Py_ABS()
using typeof() and statement expression to only evaluate each
argument once.

Test also these macros in test_cext and test_cppext to test different
compiler flags and test the limited C API.
@vstinner vstinner added the topic-C-API label Sep 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2026
C API: Implement Py_MIN(), Py_MAX() and Py_ABS() macros using typeof() #157495
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 14, 2026
vstinner added 2 commits September 14, 2026 17:40
@vstinner
Only use statement expression on GCC and clang
ad65f4d
@vstinner
Fix signed/unsigned comparisons
e28e506
@vstinner
vstinner requested review from corona10, gpshead and picnixz as code owners September 14, 2026 15:50
@vstinner

vstinner commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Oh, statement expression is a GNU extension. So it should only be used on GCC and clang.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 3 commits September 14, 2026 17:57
@vstinner
Add __extension__
be8754d
@vstinner
Update _testcapi test for Windows
9699d46
@vstinner
Merge branch 'main' into max_typeof
56d145a
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 15, 2026
@bedevere-bot

bedevere-bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 56d145a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157496%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 15, 2026
@vstinner

vstinner commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

I scheduled buildbots tests to check test_cext and test_cppext. These tests are skipped on GitHub Action CI jobs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit e2ca4dc into python:main Sep 15, 2026
124 of 125 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the max_typeof branch September 15, 2026 21:16
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 15, 2026
@ZeroIntensity ZeroIntensity mentioned this pull request Oct 7, 2026
gh-158942: restore constant-expression support in Py_MIN, Py_MAX, and Py_ABS #158943
Closed
@lpyu001 lpyu001 mentioned this pull request Oct 8, 2026
Py_MIN(), Py_MAX() and Py_ABS() cause C compatibility regressions #158942
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.