GeezerVison is showing github.com — [3.15] gh-155525: Fix quadratic f-string tokenization (GH-156756) by miss-islington · Pull Request #157828 · python/cpython
Conversation
miss-islington
commented
Sep 19, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Backport gh-156756 to Python 3.15. Retain replacement expressions in the tokenizer buffer instead of repeatedly copying the remaining source. Preserve the expression pointers when the buffer grows, and keep the interactive buffer while a formatted string is open.
Main already received the implementation through gh-156484, so the automatic cherry-pick only brought over tests. This backport also adapts the original fix to the release tokenizer and adds coverage for multiline interactive expressions, which otherwise abort in a debug build.
The targeted parser and command-line tests pass in a debug build, including the CPU-resource tests.
(cherry picked from commit c1df684)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Adapt the original expression-span fix to the release tokenizer and retain interactive buffers while a formatted string is open.
Co-authored-by: gwosti <[email protected]>
pablogsal
changed the title
[3.15] gh-155525: Cover quadratic f-string tokenization regression (GH-156756)
[3.15] gh-155525: Fix quadratic f-string tokenization (GH-156756)
Sep 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release tokenizer fix and interactive buffer retention are included. The final tree matches the debug build tested locally: 702 tests passed, including the CPU-resource cases and the new interactive regression.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
lysnikolaou
Awaiting requested review from lysnikolaou
lysnikolaou is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
tests
Tests in the Lib/test dir
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.