GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-155525: Fix quadratic f-string tokenization (GH-156756) by miss-islington · Pull Request #157828 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Backport gh-156756 to Python 3.15. Retain replacement expressions in the tokenizer buffer instead of repeatedly copying the remaining source. Preserve the expression pointers when the buffer grows, and keep the interactive buffer while a formatted string is open.

Main already received the implementation through gh-156484, so the automatic cherry-pick only brought over tests. This backport also adapts the original fix to the release tokenizer and adds coverage for multiline interactive expressions, which otherwise abort in a debug build.

The targeted parser and command-line tests pass in a debug build, including the CPU-resource tests.

(cherry picked from commit c1df684)

  • Issue: Quadratic compile() / ast.parse() time for modules with many f-strings (PEP 701 tokenizer update_fstring_expr rescans the whole remaining buffer per replacement field) #155525

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
pablogsal and others added 2 commits September 19, 2026 22:37
@pablogsal @gwosti
[ 3.15 ] pythongh-155525: Avoid quadratic f-string tokenization
2f77962
Adapt the original expression-span fix to the release tokenizer and retain interactive buffers while a formatted string is open.

Co-authored-by: gwosti <[email protected]>
@gwosti @pablogsal @miss-islington
pythongh-155525: Cover quadratic f-string tokenization regression (py…
7d0959a
…thonGH-156756)

* pythongh-155525: Avoid quadratic f-string tokenization

* fixup! pythongh-155525: Avoid quadratic f-string tokenization

---------
(cherry picked from commit c1df684)

Co-authored-by: gwosti <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington
miss-islington requested a review from lysnikolaou as a code owner September 19, 2026 22:04
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2026
Quadratic compile() / ast.parse() time for modules with many f-strings (PEP 701 tokenizer update_fstring_expr rescans the whole remaining buffer per replacement field) #155525
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Sep 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2026
gh-155525: Cover quadratic f-string tokenization regression #156756
Merged
@pablogsal pablogsal added the DO-NOT-MERGE label Sep 19, 2026
@pablogsal
Merge automatic backport with release tokenizer fix
050288f
@pablogsal
pablogsal self-requested a review as a code owner September 19, 2026 22:06
@pablogsal pablogsal changed the title [3.15] gh-155525: Cover quadratic f-string tokenization regression (GH-156756) [3.15] gh-155525: Fix quadratic f-string tokenization (GH-156756) Sep 19, 2026
@pablogsal pablogsal removed the DO-NOT-MERGE label Sep 19, 2026
pablogsal
pablogsal approved these changes Sep 19, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release tokenizer fix and interactive buffer retention are included. The final tree matches the debug build tested locally: 702 tests passed, including the CPU-resource cases and the new interactive regression.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 19, 2026
@pablogsal
pablogsal enabled auto-merge (squash) September 19, 2026 22:07
@pablogsal
pablogsal merged commit b5cbbb2 into python:3.15 Sep 19, 2026
61 of 62 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 19, 2026
@miss-islington
miss-islington deleted the backport-c1df684-3.15 branch September 19, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @pablogsal @gwosti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.