GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — [3.12] gh-157947: Keep exception fields alive during suggestion lookups by nvnzno-a11y · Pull Request #157973 · python/cpython ConversationSummary
That code can rebind or clear the exception's attributes ( This only affects 3.12 — the AttributeError suggestion path was refactored The fix takes strong references to Reproducerimport sys def fresh_name(): return ("X" * (4 * 1024 * 1024)) + "!" # mmap'd -> munmap on free class Evil: def __dir__(self): exc = getattr(sys, "last_value", None) if isinstance(exc, AttributeError): exc.name = "replaced"; exc.obj = None return ["x"] raise AttributeError("boom", name=fresh_name(), obj=Evil()) On the 3.12 branch this segfaults during exception printing Tests
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions… lookups get_suggestions_for_attribute_error(), offer_suggestions_for_name_error() and offer_suggestions_for_import_error() used borrowed references to exc->name/exc->obj/exc->name_from and the traceback frame across calls that can invoke arbitrary Python code (PyObject_Dir, PyImport_GetModule, _PyObject_LookupAttr). That code can rebind or clear the exception's attributes and free the referenced objects, leaving dangling pointers that calculate_suggestions() then dereferences -> use-after-free. Take strong references for the duration of the calls that may run arbitrary code.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |