GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-158063: Fix out-of-bounds read when comparing decimal signal dicts by lazerg · Pull Request #158069 · python/cpython

Conversation

@lazerg

@lazerg lazerg commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

signaldict_richcompare() checked SdFlagAddr(w) before it knew w was a signal dict, so comparing flags or traps with anything else (e.g. None) read the flags pointer from past the end of that object. The NULL check on w now only runs when w is a signal dict. Other objects fall through to the existing dict/NotImplemented handling.

  • Issue: AddressSanitizer: global-buffer-overflow Modules/_decimal/_decimal.c:798:37 in signaldict_richcompare #158063

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lazerg
pythongh-158063: Fix out-of-bounds read when comparing decimal signal…
94e83cd 
… dicts
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2026
AddressSanitizer: global-buffer-overflow Modules/_decimal/_decimal.c:798:37 in signaldict_richcompare #158063
Open
@bedevere-app bedevere-app Bot added the awaiting review label Sep 24, 2026
@lazerg lazerg closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@lazerg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.