GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-155496: Use Argument Clinic for more functions of the _csv module by serhiy-storchaka · Pull Request #158133 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 24, 2026

Copy link
Copy Markdown
Member

Convert reader(), writer(), register_dialect(), Dialect.__reduce__(), Dialect.__reduce_ex__() and Dialect.__replace__() from PyArg_ParseTuple()/PyArg_UnpackTuple() to Argument Clinic, so that they have a signature for introspection and use a faster calling convention.

__reduce__() and __reduce_ex__() shared one METH_VARARGS implementation which ignored its arguments; they are now separate functions, and __reduce_ex__() declares the protocol argument.

  • Issue: Use Argument Clinic for more functions and methods #155496

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-155496: Use Argument Clinic for more functions of the _csv m…
a6014dc 
…odule
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 24, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2026
Use Argument Clinic for more functions and methods #155496
Closed
@serhiy-storchaka serhiy-storchaka added the skip news label Sep 27, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 93142c9 into python:main Sep 27, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 27, 2026
@serhiy-storchaka
serhiy-storchaka deleted the csv-clinic branch September 27, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.