GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-153480: Stop IDLE crashing when a file open in the editor is deleted (GH-153481) by miss-islington · Pull Request #158262 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

EditorWindow.focus_in_event calls last_mtime on every event,
which passed the open file path to os.path.getmtime with no guard. When
another program deleted or renamed the file, refocusing the IDLE window
let a FileNotFoundError escape the Tk event handler. last_mtime now
returns the last known mtime when the path is inaccessible, so refocusing
no longer raises and does not prompt to reload a file that is gone.
See PR discussion for more.

(cherry picked from commit 6af40a6)

Co-authored-by: tonghuaroot (童话) [email protected]
Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: IDLE fails to start or raises when an editor window's file does not exist #153480

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tonghuaroot @serhiy-storchaka @miss-islington
pythongh-153480: Stop IDLE crashing when a file open in the editor is…
df9eff9 
… deleted (pythonGH-153481)

EditorWindow.focus_in_event calls last_mtime on every <FocusIn> event,
which passed the open file path to os.path.getmtime with no guard. When
another program deleted or renamed the file, refocusing the IDLE window
let a FileNotFoundError escape the Tk event handler. last_mtime now
returns the last known mtime when the path is inaccessible, so refocusing
no longer raises and does not prompt to reload a file that is gone.
See PR discussion for more.

---------
(cherry picked from commit 6af40a6)

Co-authored-by: tonghuaroot (童话) <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner September 27, 2026 01:13
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
IDLE fails to start or raises when an editor window's file does not exist #153480
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Sep 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
gh-153480: Stop IDLE crashing when a file open in the editor is deleted #153481
Merged
@terryjreedy
terryjreedy enabled auto-merge (squash) September 27, 2026 01:14
@terryjreedy
terryjreedy merged commit cbc7753 into python:3.14 Sep 27, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 27, 2026
@miss-islington
miss-islington deleted the backport-6af40a6-3.14 branch September 27, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @terryjreedy @tonghuaroot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.