GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-158102: Add tests for the slice C API (GH-158120) by serhiy-storchaka · Pull Request #158292 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 27, 2026

Copy link
Copy Markdown
Member

Test PySlice_Check(), PySlice_New(), PySlice_GetIndices(), PySlice_Unpack(), PySlice_AdjustIndices() and PySlice_GetIndicesEx().

PySlice_GetIndicesEx() is tested both as a macro and as a deprecated function, including the case when __index__() resizes the sequence whose size is passed as the length: the macro evaluates it after PySlice_Unpack(), the function before the call.

(cherry picked from commit 8c056c3)

The conflicts were only in the registration lists, which have diverged from main: Modules/Setup.stdlib.in, Modules/_testlimitedcapi.c, Modules/_testlimitedcapi/parts.h and the two PCbuild files. Modules/_testlimitedcapi has no slots.c here, so slice.c is registered between set.c and sys.c, and the registration calls are in PyInit__testlimitedcapi(), which returns PyObject *, so the new check returns NULL instead of -1.

In Modules/_testlimitedcapi/slice.c, Py_TARGET_ABI3T does not exist in 3.14 -- there is no Include/pyabi.h -- so the limited C API is simply not tested in a free-threading build, like in the other files of Modules/_testlimitedcapi.

  • Issue: Add C API tests for the slice C API #158102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @claude @vstinner
[3.14] pythongh-158102: Add tests for the slice C API (pythonGH-158120)
1705310
Test PySlice_Check(), PySlice_New(), PySlice_GetIndices(), PySlice_Unpack(),
PySlice_AdjustIndices() and PySlice_GetIndicesEx() -- both the macro and the
deprecated function.

Document the length and step precondition of PySlice_AdjustIndices()
(cherry picked from commit 8c056c3)

Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka
serhiy-storchaka requested review from a team and erlend-aasland as code owners September 27, 2026 17:34
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
Add C API tests for the slice C API #158102
Closed
@bedevere-app bedevere-app Bot added awaiting core review skip news labels Sep 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
gh-158102: Add tests for the slice C API #158120
Merged
@read-the-docs-community

read-the-docs-community Bot commented Sep 27, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34789787 | 📁 Comparing 1705310 against main (baec764)

  🔍 Preview build  

310 files changed · + 1 added · ± 288 modified · - 21 deleted

+ Added

  • library/asyncio-policy.html

± Modified

  • about.html
  • bugs.html
  • glossary.html
  • index.html
  • license.html
  • py-modindex.html
  • builtins/exceptions.html
  • builtins/functions.html
  • builtins/stdtypes.html
  • builtins/time-complexity.html
  • and 278 more...

- Deleted

  • _static/tachyon-example-flamegraph.html
  • _static/tachyon-example-heatmap.html
  • c-api/sentinel.html
  • c-api/slots.html
  • deprecations/c-api-pending-removal-in-3.19.html
  • deprecations/c-api-pending-removal-in-3.20.html
  • deprecations/pending-removal-in-3.20.html
  • deprecations/pending-removal-in-3.21.html
  • deprecations/soft-deprecations.html
  • extending/first-extension-module.html
  • and 11 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka merged commit fe0482a into python:3.14 Sep 29, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.