GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898) by miss-islington · Pull Request #158299 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

_Py_hashtable_set() returns -1 on failure, so the "< -1" check could never be true and the Py_FatalError() call was unreachable.
(cherry picked from commit a4eb936)

Co-authored-by: Rishi Raj [email protected]

  • Issue: intern_static() never detects a failed _Py_hashtable_set() (< -1 should be < 0) #157892

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rishiraj38 @miss-islington
pythongh-157892: Fix error check on _Py_hashtable_set() in intern_sta…
d8ace2a 
…tic() (pythonGH-157898)

_Py_hashtable_set() returns -1 on failure, so the "< -1" check could never be true and the Py_FatalError() call was unreachable.
(cherry picked from commit a4eb936)

Co-authored-by: Rishi Raj <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
intern_static() never detects a failed _Py_hashtable_set() (< -1 should be < 0) #157892
Closed
@bedevere-app bedevere-app Bot added awaiting review skip news labels Sep 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2026
gh-157892: Fix error check on _Py_hashtable_set() in intern_static() #157898
Merged
@Yhg1s
Merge branch '3.13' into backport-a4eb936-3.13
31cc897
@Yhg1s
Yhg1s enabled auto-merge (squash) September 29, 2026 21:38
@Yhg1s
Yhg1s merged commit 036d2d6 into python:3.13 Sep 29, 2026
40 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 29, 2026
@miss-islington
miss-islington deleted the backport-a4eb936-3.13 branch September 29, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @Yhg1s @rishiraj38
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.