GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable missing `TestJsonEncoding` tests by hugovk · Pull Request #158668 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The threading_helper.reap_threads decorator is intended for test functions, not classes, and applying it to the class means it didn't run:

0:10:15 load avg: 11.08 mem: 230.8 MiB [394/558/1] test.test_free_threading.test_json ran no tests

https://github.com/python/cpython/actions/runs/37135589260/job/111239394429#step:19:2263

Removing it allows the tests to run:

0:06:14 load avg: 9.65 mem: 308.6 MiB [349/558] test.test_free_threading.test_json passed -- running (2): test_zipfile (34.5 sec), test_regrtest (1 min 19 sec)

https://github.com/hugovk/cpython/actions/runs/37135650674/job/111251480717#step:19:391

This wasn't visible before #158620 (except for occasional re-runs).

Originally added in #119438, cc @eendebakpt.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eendebakpt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
Enable TestJsonEncoding tests
c52c125
@hugovk hugovk added the tests Tests in the Lib/test dir label Oct 3, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 3, 2026
@hugovk hugovk added needs backport to 3.15 bugs and security fixes skip issue skip news labels Oct 3, 2026
eendebakpt
eendebakpt approved these changes Oct 3, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 3, 2026
@StanFromIreland StanFromIreland mentioned this pull request Oct 6, 2026
Fix @reap_threads usage in test_free_threading.test_json #158937
Merged
@vstinner

vstinner commented Oct 6, 2026

Copy link
Copy Markdown
Member

Hi. I also discovered this issue and I wrote PR #158937 to fix it. @StanFromIreland told me that @hugovk already wrote this fix.

My PR moves @reap_threads on each test method rather than removing it, and it also adds a check to @reap_threads to detect misusage of the decorator (fails if the argument is a class).

Would you mind to review my change? #158937
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 10, 2026

Copy link
Copy Markdown
Member

I merged my change instead: #158937. Thanks for your fix anyway @hugovk!
hugovk reacted with thumbs up emoji hugovk reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 10, 2026
@hugovk
hugovk deleted the 3.16-enable-missed-tests branch October 10, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpt eendebakpt eendebakpt approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.15 bugs and security fixes skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @vstinner @eendebakpt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.