GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-158196: Fix double free of FileIO stat_atopen by BHUVANSH855 · Pull Request #159153 · python/cpython

Conversation

@BHUVANSH855

@BHUVANSH855 BHUVANSH855 commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

internal_close() frees self->stat_atopen after the if (self->fd >= 0) block instead of inside it, so two threads closing the same unbuffered FileIO can both read the same pointer and free it. _io_FileIO_truncate_impl() does the same. GIL build isn't affected.

Fixed with an atomic exchange so only one thread gets the pointer. PyMem_Free(NULL) is a no-op so the NULL check in truncate() goes too. I didn't bother with #ifdef Py_GIL_DISABLED, it's one atomic next to a close(2), but I can add it.

Left alone: readall(), _isatty_open_only() and _blksize read the pointer unsynchronised and can see a freed block. Not new, and bounded, readall() clamps with st_size < _PY_READ_MAX so worst case is a bad size guess.
Fixing it needs QSBR or a lifetime change, same design question as GH-151708, so I'd do it separately. __init__ is unsynchronised too.

Linux x86-64, gcc 13.3, --disable-gil --with-pydebug: reproducer crashed 4/4 before (0xdd pattern, one mimalloc: corrupted free list entry), 0/5 after. test_io and test_free_threading pass. Compiles clean on a GIL build.

No test yet, the obvious one is timing dependent and I'd rather bring it with the follow-up. Can add it now if you want.

Same change for 3.15 and 3.14. 3.13 stores a plain int and isn't affected.

  • Issue: Free-threading: concurrent FileIO close/truncate can double-free stat_atopen #158196

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@BHUVANSH855
pythongh-158196: Fix double free of FileIO stat_atopen
ee222db
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2026
Free-threading: concurrent FileIO close/truncate can double-free stat_atopen #158196
Open
@bedevere-app bedevere-app Bot added the awaiting review label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@BHUVANSH855
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.