GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-129813: Check size in PyBytesWriter_FinishWithSize() (#157226) by vstinner · Pull Request #159261 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 12, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reject size larger than the allocated size.

Check also negative size in PyBytesWriter_FinishWithSize() to always raise ValueError. Previously, the function raised SystemError or ValueError depending on the code path.

Replace _PyBytesWriter_GetAllocated() optimization with _PyBytesWriter_ResizeToAllocated() to update the writer size to its allocated size.

test_capi: only run the 3 "example" tests in BytesWriterTest. There is no need to rerun the same tests in ByteArrayWriterTest.

(cherry picked from commit 4e530b8)

  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-129813: Check size in PyBytesWriter_FinishWithSize() (python…
33f8c2c
…#157226)

Reject size larger than the allocated size.

Check also negative size in PyBytesWriter_FinishWithSize() to always
raise ValueError. Previously, the function raised SystemError or
ValueError depending on the code path.

Replace _PyBytesWriter_GetAllocated() optimization with
_PyBytesWriter_ResizeToAllocated() to update the writer size to its
allocated size.

test_capi: only run the 3 "example" tests in BytesWriterTest. There
is no need to rerun the same tests in ByteArrayWriterTest.

(cherry picked from commit 4e530b8)
@vstinner vstinner added skip news needs backport to 3.15 bugs and security fixes labels Oct 12, 2026
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2026
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2026
gh-129813: Check size in PyBytesWriter_FinishWithSize() #157226
Merged
@vstinner vstinner removed the type-feature A feature request or enhancement label Oct 12, 2026
@vstinner
vstinner enabled auto-merge (squash) October 12, 2026 21:11
@vstinner
vstinner merged commit c38a347 into python:3.15 Oct 12, 2026
56 of 61 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the writer_size15 branch October 12, 2026 21:32
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 12, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker c38a347e2c3199d7d3f6a9eefbf46df52caf725d 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned vstinner Oct 12, 2026
@vstinner vstinner removed the needs backport to 3.15 bugs and security fixes label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.