GeezerVison is showing github.com — gh-159266: Don't reify lazy imports when completing global names in the REPL by brittanyrey · Pull Request #159267 · python/cpython
Conversation
brittanyrey
commented
Oct 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Tab completing within the REPL was triggering a reify of any lazily imported module whose name matched the completer. Instead, we can look up the value directly in the namespace & finally in the builtins.
With this change you will not get colors for a lazily imported module/object until it is reified.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
fancycompleter's global_matches() eval()ed every matching name to pick
its color, which imported lazily imported modules on <Tab>. Look the
value up in the namespace and builtins instead, as rlcompleter does.
With this change you will not get colours for a lazily imported module/object until it is reified.
In my opinion, the trade-off doesn't seem worth it, in the repl, I think users care more about the colours than the performance.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.