GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-157649: Merge test_cppext into test_cext (#158176) (#159264) by vstinner · Pull Request #159276 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 12, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • test_cext now uses a single virtual environment for all tests. It makes the test way faster since creating a virtual environment is quite slow.
  • Add Py_TARGET_ABI3T test on C++.
  • Move macro tests from module exec function to test_macros().
  • Call Py_BEGIN_CRITICAL_SECTION() on a fresh dictionary object, rather than on the module.
  • Rename some environment variables to always use "CPYTHON_TEST_" prefix.
  • Replace support.MS_WINDOWS with MSVC to be more explicit.
  • Move macro tests to test_macros().
  • On macOS, use C++11 by default.

(cherry picked from commit b71989d) (cherry picked from commit 364db5d)

  • Issue: Py_CLEAR/Py_SETREF() regression on the main branch with C++: SEGV with simple numpy program #157649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
[3.15] pythongh-157649: Merge test_cppext into test_cext (python#158176…
d2890a6 
…) (python#159264)

* test_cext now uses a single virtual environment for all tests.
  It makes the test way faster since creating a virtual environment
  is quite slow.
* Add Py_TARGET_ABI3T test on C++.
* Move macro tests from module exec function to test_macros().
* Call Py_BEGIN_CRITICAL_SECTION() on a fresh dictionary object,
  rather than on the module.
* Rename some environment variables to always use "CPYTHON_TEST_"
  prefix.
* Replace support.MS_WINDOWS with MSVC to be more explicit.
* Move macro tests to test_macros().
* On macOS, use C++11 by default.

(cherry picked from commit b71989d)
(cherry picked from commit 364db5d)
@vstinner
vstinner requested a review from erlend-aasland as a code owner October 12, 2026 22:56
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2026
Py_CLEAR/Py_SETREF() regression on the main branch with C++: SEGV with simple numpy program #157649
Closed
@bedevere-app bedevere-app Bot added awaiting core review skip news labels Oct 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2026
[3.15] gh-157649: Merge test_cppext into test_cext (#158176) #159264
Merged
@vstinner
Fix warning about unused dict
3453e44
@vstinner

vstinner commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

!buildbot s390x Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 13, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 3453e44 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159276%2Fmerge

The command will test the builders whose names match following regular expression: s390x Fedora Stable PR

The builders matched are:

  • s390x Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) October 13, 2026 06:44
@vstinner
vstinner merged commit 1d0f58b into python:3.14 Oct 13, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the merge_test_cppext14 branch October 13, 2026 06:47
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 13, 2026
chris-eibl
chris-eibl reviewed Oct 13, 2026
View reviewed changes
Comment thread Lib/test/test_cext/__init__.py
def test_build_c11(self):
self.check_build('_test_cext_c11', std='c11')

def test_build_limited(self):

@chris-eibl chris-eibl Oct 13, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, IIUC, this is no longer skipped for free threading and thus fails e.g. AMD64 CentOS9 NoGIL 3.14: https://buildbot.python.org/?#/builders/1733/builds/2119/steps/5/logs/stdio:

/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Include/Python.h:52:4:
error: #error "The limited API is not currently supported in the free-threaded build"

I wonder why it passed in CI and on so many other no-gil bots?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Oct 13, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote #159371 to skip limited C API tests on Free Threading.

I forgot to test this case locally, and GitHub Action jobs skip test_cext.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl reacted with thumbs up emoji chris-eibl reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

@chris-eibl chris-eibl Oct 13, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Action jobs skip test_cext

Ah, yes, due to --fast-ci. But why is it then not listed under "tests skipped"?

And why did other no-gil bots pass that use --slow-ci?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl left review comments
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.