GeezerVison

ZipFile.__del__ emitted its ResourceWarning before calling close().
When warnings.warn() raised, close() was skipped and the central
directory of a writable archive was never written, leaving a corrupt
file. This happens at interpreter shutdown, where resolving the lazy
"warnings" import raises ImportError, and with -W
error::ResourceWarning at any time.

Call close() in a finally block.

msullivan left a comment

cmaloney left a comment

vstinner left a comment

Keep a reference to warnings.warn as a default argument, like
subprocess.Popen.__del__, and always call close() even if emitting the
ResourceWarning raises. Verify the archive contents after collection
so the test catches a skipped close(). Shorten the NEWS entry.