GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — [3.14] gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach by vstinner · Pull Request #159600 · python/cpython Conversation
Member
TextIOWrapper keeps its underlying stream in a member called The cases which need to be re-checked are hard to spot so rather than rely on reviewer effort create better safety by making all self->buffer access go through helper functions. Thank you yihong0618 for the test, NEWS and initial implementation in gh-143041. (cherry picked from commit db4b194)
(cherry picked from commit 8440a6a)
(cherry picked from commit e19dc47) (cherry picked from commit ea1312b)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions… reentrant detach (python#159591) * pythongh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access (python#145957) TextIOWrapper keeps its underlying stream in a member called `self->buffer`. That stream can be detached by user code, such as custom `.flush` implementations resulting in `self->buffer` being set to NULL. The implementation often checked at the start of functions if `self->buffer` is in a good state, but did not always recheck after other Python code was called which could modify `self->buffer`. The cases which need to be re-checked are hard to spot so rather than rely on reviewer effort create better safety by making all self->buffer access go through helper functions. Thank you yihong0618 for the test, NEWS and initial implementation in pythongh-143041. Co-authored-by: yihong0618 <[email protected]> Co-authored-by: Victor Stinner <[email protected]> (cherry picked from commit db4b194) * pythongh-154523: Fix data-race in `TextIOWrapper.detach()` (python#154565) (cherry picked from commit 8440a6a) * pythongh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach (python#157370) Co-authored-by: Victor Stinner <[email protected]> (cherry picked from commit e19dc47) --------- Co-authored-by: Cody Maloney <[email protected]> Co-authored-by: yihong0618 <[email protected]> Co-authored-by: Brij Kapadia <[email protected]> Co-authored-by: Shamil <[email protected]> (cherry picked from commit ea1312b)
vstinner
enabled auto-merge (squash)
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |