GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159561: Remove redundant type check in AF_VSOCK setsockopt() by lazerg · Pull Request #159610 · python/cpython

Conversation

@lazerg

@lazerg lazerg commented Oct 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The AF_VSOCK branch of sock_setsockopt() set a TypeError for a non-int option value but kept going, so PyArg_Parse() ran with an exception already pending. The check is redundant since the K converter already rejects non-int values, so I removed it.

Fixes #159561

  • Issue: useless AF_VSOCK setsockopt validation code #159561

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lazerg
pythongh-159561: Return early on non-int optval in AF_VSOCK setsockopt()
f050971
@bedevere-app bedevere-app Bot added the awaiting review label Oct 17, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 17, 2026
useless AF_VSOCK setsockopt validation code #159561
Closed
benjaminp
benjaminp reviewed Oct 17, 2026
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work to delete this whole block? PyArg_Parse will validate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lazerg
Drop the AF_VSOCK type check, PyArg_Parse already validates
2b7ac5a
@lazerg lazerg changed the title gh-159561: Return early on non-int optval in AF_VSOCK setsockopt() gh-159561: Remove redundant type check in AF_VSOCK setsockopt() Oct 18, 2026
@lazerg

lazerg commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Yes, it works. The K converter does its own index check and raises a TypeError, so I removed the block in 2b7ac5a.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjaminp benjaminp added the skip news label Oct 18, 2026
benjaminp
benjaminp approved these changes Oct 18, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 18, 2026
@benjaminp
benjaminp enabled auto-merge (squash) October 18, 2026 04:08
@benjaminp
benjaminp merged commit 03a3f3d into python:main Oct 18, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 18, 2026
@bvolpato bvolpato mentioned this pull request Nov 9, 2026
AF_VSOCK sockets reject buffered SOL_SOCKET options #161657
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useless AF_VSOCK setsockopt validation code

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lazerg @benjaminp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.