GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159815: do not leave stale OpenSSL errors in `_hashlib` by picnixz · Pull Request #159816 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Oct 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Do not leave stale OpenSSL errors in _hashlib #159815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@picnixz
pythongh-159815: do not leave stale OpenSSL errors in _hashlib
5e0a106
`raise_unsupported_algorithm_impl()` peeked the OpenSSL error queue without
clearing it on the `ERR_R_UNSUPPORTED` and `ERR_R_FETCH_FAILED` branches,
so a later unrelated failure in the same thread reported the earlier error.

Clear the queue in those branches, and clear it in callers before the
OpenSSL operations whose failure is reported by that function or before
calling `get_asn1_utf8name_by_nid()`, which inspects the last error.
@picnixz
picnixz requested a review from gpshead as a code owner October 19, 2026 23:58
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Do not leave stale OpenSSL errors in _hashlib #159815
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 19, 2026
picnixz added 2 commits October 19, 2026 16:58
@picnixz
add NEWS entry
16cd716
@picnixz
add test
0a4837e
@picnixz picnixz added needs backport to 3.15 bugs and security fixes sprint labels Oct 20, 2026
@github-project-automation github-project-automation Bot added this to Sprint Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 20, 2026
@picnixz picnixz self-assigned this Oct 20, 2026
@picnixz
Merge branch 'main' into meta/crypto/c/hashlib/34/openssl-peek-error-…
61f6e5e
…159815
@picnixz
picnixz marked this pull request as draft October 20, 2026 19:51
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 20, 2026
gpshead
gpshead approved these changes Oct 22, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 22, 2026
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Oct 22, 2026
@picnixz

picnixz commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

FTR, there are still issues with that branch actually (I found more locally)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@picnixz picnixz

Labels

awaiting merge needs backport to 3.15 bugs and security fixes sprint

Projects

Sprint
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.