GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-159786: Convert HACL* update() errors in `_hmac` after releasing the lock (GH-159805) by miss-islington · Pull Request #159825 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 20, 2026

Copy link
Copy Markdown
Contributor
  • HACL* update() errors are handled without a thread state #159786: Convert HACL* update() errors in _hmac after releasing the lock

_hacl_hmac_state_update_once() converted the HACL* exit code into an
exception while the thread state was detached and, for HMAC.update(),
while the object's mutex was held. On debug builds, this re-attached the
thread state under the mutex and then called PyErr_Occurred() with the
thread state detached in the chunking loop of _hacl_hmac_state_update().

Return the raw HACL* exit code instead and convert it in _hmac.new() and
_hmac.HMAC.update() once the thread state is re-attached and the mutex
is released, as hmac_digest_compute_locked() already does. Release
builds keep ignoring the update() exit code.

Since _hacl_convert_errno() is now always called with an attached
thread state, remove the PyGILState_Ensure() added by gh-135561 and
assert that a thread state is attached instead.

  • simplify ifdefs: always check for the hacl error

(cherry picked from commit 0fba211)

Co-authored-by: Bénédikt Tran [email protected]
Co-authored-by: Gregory P. Smith [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@picnixz @gpshead @miss-islington
pythongh-159786: Convert HACL* update() errors in _hmac after relea…
2e470c3
…sing the lock (pythonGH-159805)

* pythongh-159786: Convert HACL* update() errors in `_hmac` after releasing the lock

`_hacl_hmac_state_update_once()` converted the HACL* exit code into an
exception while the thread state was detached and, for HMAC.update(),
while the object's mutex was held. On debug builds, this re-attached the
thread state under the mutex and then called PyErr_Occurred() with the
thread state detached in the chunking loop of `_hacl_hmac_state_update()`.

Return the raw HACL* exit code instead and convert it in `_hmac.new()` and
`_hmac.HMAC.update()` once the thread state is re-attached and the mutex
is released, as `hmac_digest_compute_locked()` already does. Release
builds keep ignoring the update() exit code.

Since `_hacl_convert_errno()` is now always called with an attached
thread state, remove the `PyGILState_Ensure()` added by pythongh-135561 and
assert that a thread state is attached instead.

* simplify ifdefs: always check for the hacl error

---------
(cherry picked from commit 0fba211)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested review from gpshead and picnixz as code owners October 20, 2026 00:55
@bedevere-app bedevere-app Bot added the awaiting review label Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
HACL* update() errors are handled without a thread state #159786
Closed
@bedevere-app bedevere-app Bot added the sprint label Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
gh-159786: Convert HACL* update() errors in _hmac after releasing the lock #159805
Merged
@github-project-automation github-project-automation Bot added this to Sprint Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 20, 2026
picnixz
picnixz approved these changes Oct 20, 2026
View reviewed changes
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 20, 2026
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Oct 20, 2026
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 20, 2026
@picnixz
picnixz enabled auto-merge (squash) October 20, 2026 19:49
@picnixz
picnixz merged commit 4250c67 into python:3.15 Oct 20, 2026
62 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 20, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Oct 20, 2026
@miss-islington
miss-islington deleted the backport-0fba211-3.15 branch October 20, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.