GeezerVison is showing github.com — [3.15] gh-159811: Raise OpenSSL errors in `_hashlib.HMAC` after re-attaching the thread state (GH-159818) by miss-islington · Pull Request #159926 · python/cpython
Conversation
miss-islington
commented
Oct 20, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
hashlib_openssl_HMAC_update_once() set an exception when the OpenSSL
HMAC update function failed, but it was called inside a GIL-released
region and the object's mutex held by _hashlib.HMAC.update() and
_hashlib.hmac_new() when the data exceeds HASHLIB_GIL_MINSIZE bytes.
Instead, the HMAC update function is called directly in _hmac_update(),
and the exception is set once the thread state is re-attached and the mutex
is released (restores the behavior prior to gh-134531).
Since the OpenSSL error queue is per thread, the exception type and message
are unaffected.
(cherry picked from commit b4b81e1)
Co-authored-by: Bénédikt Tran [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…aching the thread state (pythonGH-159818)
`hashlib_openssl_HMAC_update_once()` set an exception when the OpenSSL
HMAC update function failed, but it was called inside a GIL-released
region and the object's mutex held by `_hashlib.HMAC.update()` and
`_hashlib.hmac_new()` when the data exceeds `HASHLIB_GIL_MINSIZE` bytes.
Instead, the HMAC update function is called directly in `_hmac_update()`,
and the exception is set once the thread state is re-attached and the mutex
is released (restores the behavior prior to pythongh-134531).
Since the OpenSSL error queue is per thread, the exception type and message
are unaffected.
(cherry picked from commit b4b81e1)
Co-authored-by: Bénédikt Tran <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
picnixz
picnixz approved these changes
gpshead
Awaiting requested review from gpshead
gpshead is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.