GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-158197: Fix split dict iteration during concurrent deletion (gh-158686) by miss-islington · Pull Request #159953 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Read insertion order from the iterator's captured values snapshot instead
of re-reading ma_values and asserting against a concurrently changing
size. Retry under the dictionary lock when a value slot has been cleared.

Make insertion-order writes atomic and publish size changes with release
stores, pairing with the iterator's size load. Keep order-byte accesses
relaxed. Add _Py_atomic_store_uint8_release() and
FT_ATOMIC_STORE_UINT8_RELEASE() for this.
(cherry picked from commit 4bb1dad)

Co-authored-by: Neil Schemenauer [email protected]

  • Issue: Free-threading: iterating an instance dict can crash during concurrent deletion #158197

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nascheme @miss-islington
pythongh-158197: Fix split dict iteration during concurrent deletion (p…
df9d356
…ythongh-158686)

Read insertion order from the iterator's captured values snapshot instead
of re-reading ma_values and asserting against a concurrently changing
size. Retry under the dictionary lock when a value slot has been cleared.

Make insertion-order writes atomic and publish size changes with release
stores, pairing with the iterator's size load. Keep order-byte accesses
relaxed. Add _Py_atomic_store_uint8_release() and
FT_ATOMIC_STORE_UINT8_RELEASE() for this.
(cherry picked from commit 4bb1dad)

Co-authored-by: Neil Schemenauer <[email protected]>
@miss-islington
miss-islington requested review from markshannon and methane as code owners October 20, 2026 19:33
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
gh-158197: Fix split dict iteration during concurrent deletion #158686
Merged
@bedevere-app bedevere-app Bot added topic-free-threading type-bug An unexpected behavior, bug, or error labels Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
Free-threading: iterating an instance dict can crash during concurrent deletion #158197
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 20, 2026
@JelleZijlstra
JelleZijlstra merged commit 74a2677 into python:3.15 Oct 21, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Oct 21, 2026
@miss-islington
miss-islington deleted the backport-4bb1dad-3.15 branch October 21, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @JelleZijlstra @nascheme
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.