GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159973: Highlight soft keywords after `token.NL` / `token.DEDENT` by johnslavik · Pull Request #159992 · python/cpython

Conversation

@johnslavik

@johnslavik johnslavik commented Oct 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Before:
Screenshot 2026-10-20 at 16 30 16

After:
Screenshot 2026-10-20 at 16 30 44

  • Issue: Soft keyword highlighting issues on continuation lines #159973

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NekoAsakura reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@johnslavik
Highlight soft keywords after token.NL
fb7e209
@johnslavik
johnslavik requested review from ambv, lysnikolaou and pablogsal as code owners October 20, 2026 23:28
@johnslavik johnslavik added the sprint label Oct 20, 2026
@github-project-automation github-project-automation Bot added this to Sprint Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
Soft keyword highlighting issues on continuation lines #159973
Open
@bedevere-app bedevere-app Bot added the awaiting review label Oct 20, 2026
@johnslavik johnslavik added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 20, 2026
@NekoAsakura

This comment was marked as resolved.

Sign in to view
@johnslavik
Highlight match statements after dedents
b701ca1
@johnslavik johnslavik changed the title gh-159973: Highlight soft keywords after token.NL gh-159973: Highlight soft keywords after token.NL / token.DEDENT Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

Thank you @NekoAsakura!
NekoAsakura reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NekoAsakura
NekoAsakura approved these changes Oct 21, 2026
View reviewed changes

@NekoAsakura NekoAsakura left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Oct 21, 2026
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

There's still false positives like match() or case =, brewing on those
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@NekoAsakura

NekoAsakura commented Oct 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I put together the failing patterns I found below, and it might be worth a separate PR to fix them.
pr159992_soft_keyword_bugs

Edit: case = looks fine on my end.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Oct 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

case = looks fine on my end. -- sorry, I meant case even outside of match, which you caught above as well. Thank you for working on this!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NekoAsakura NekoAsakura NekoAsakura approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes sprint

Projects

Sprint
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@johnslavik @NekoAsakura
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.