GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-129605: Add more exception handling when computing suggestions in traceback.py (GH-129632) by ambv · Pull Request #159994 · python/cpython

Conversation

@ambv

@ambv ambv commented Oct 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Backport of #129632 to the 3.14 branch.

Conflict in Lib/traceback.py resolved manually: main has newer not_normalized logic that does not exist on 3.14, so the backport wraps 3.14's NameError frame-walking block in try/except Exception: return None exactly as the original PR does, minus the not_normalized lines.

  • Issue: traceback._compute_suggestion_error crashes on __getattr__ raising #129605

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ADThomas-astro @ambv
[3.14] pythongh-129605: Add more exception handling when computing su…
5655fa6 
…ggestions in traceback.py (pythonGH-129632)

(cherry picked from commit 97b5f24)

Co-authored-by: Adam D. Thomas <[email protected]>
Co-authored-by: Muse Code (Meta Muse Spark)
This was referenced Oct 20, 2026
gh-129605: Add more exception handling when computing suggestions in traceback.py #129632
Merged
traceback._compute_suggestion_error crashes on __getattr__ raising #129605
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 20, 2026
@ambv
ambv merged commit a14a97f into python:3.14 Oct 21, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 21, 2026
@ambv
ambv deleted the backport-97b5f24-3.14 branch October 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ambv @ADThomas-astro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.