GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148228: Render REPL error overlays in brackets and non-bold red by johnslavik · Pull Request #160008 · python/cpython

Conversation

@johnslavik

@johnslavik johnslavik commented Oct 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Render REPL error overlays as [ error message ], analogous to completion messages such as [ not unique ]. The brackets distinguish errors from stdout even when color is disabled. When color is enabled, the whole message uses non-bold red.

For example, ! nothing to yank becomes [ nothing to yank ].

  • Issue: Enable error overlays in the REPL #148228

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johnslavik
Render REPL error overlays in red without a prefix
93dd613
@johnslavik
johnslavik requested review from ambv, lysnikolaou and pablogsal as code owners October 21, 2026 02:02
@johnslavik johnslavik added the sprint label Oct 21, 2026
@github-project-automation github-project-automation Bot added this to Sprint Oct 21, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 21, 2026
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 21, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 21, 2026
Enable error overlays in the REPL #148228
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hmmm or maybe we should do [ error message ] analogous to [ not unique ]?
So that in no-color it's less likely to be confused with stdout.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
Bracket REPL error overlay messages
8f151e6
@johnslavik johnslavik changed the title gh-148228: Render REPL error overlays in red without a prefix gh-148228: Render REPL error overlays in brackets and non-bold red Oct 21, 2026
@johnslavik

johnslavik commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

We're golden
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

I'll merge main to fix a flake
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
Merge branch 'main' into repl-red-error-overlays
dd5de26
ambv
ambv reviewed Oct 23, 2026
View reviewed changes
Comment thread Lib/_pyrepl/reader.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
Use THEME properly
63a8b7e
@johnslavik

johnslavik commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@ambv do you think we should use [ {} ] template or are we fine hardcoding the brackets?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik
fix tests too
67e71e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review sprint type-feature A feature request or enhancement

Projects

Sprint
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@johnslavik @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.