GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159739: Propagate float rounding allocation failures by jelle-openai · Pull Request #160195 · python/cpython

Conversation

@jelle-openai

@jelle-openai jelle-openai commented Oct 22, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

If the decimal-to-binary conversion inside round(float, ndigits) runs out of memory, it returns a -1.0 error sentinel and sets errno to ENOMEM. Ignoring that error can return -1.0 as a seemingly successful rounded value. Raise MemoryError instead. Backport to 3.15 and 3.14.

  • Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jelle-openai
pythongh-159739: Propagate float rounding allocation failures
7e95506 
If the decimal-to-binary conversion inside round(float, ndigits) runs out of memory, it returns a -1.0 error sentinel and sets errno to ENOMEM. Ignoring that error can return -1.0 as a seemingly successful rounded value. Raise MemoryError instead. Backport to 3.15 and 3.14.
@bedevere-app bedevere-app Bot added the awaiting review label Oct 22, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 22, 2026
Fix minor safety issues #159739
Open
StanFromIreland
StanFromIreland reviewed Oct 22, 2026
View reviewed changes
Comment thread Objects/floatobject.c
_Py_SET_53BIT_PRECISION_END;
if (errno == ERANGE && fabs(rounded) >= 1.)
if (errno == ENOMEM)
PyErr_NoMemory();

@StanFromIreland StanFromIreland Oct 22, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we follow PEP 7 please?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jelle-openai
pythongh-159739: Use braces in float rounding error handling
af72bd0 
The float rounding allocation-failure check extended an unbraced conditional chain, contrary to the C style required for modified code. Add braces to its branches without changing their behavior. Backport to 3.15 and 3.14.
StanFromIreland
StanFromIreland approved these changes Oct 22, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 22, 2026
@StanFromIreland
StanFromIreland enabled auto-merge (squash) October 22, 2026 18:27
@StanFromIreland
StanFromIreland merged commit 3e7393b into python:main Oct 22, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jelle-openai @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.