GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-159739: Fully clear the unpickler memo (GH-160173) by jelle-openai · Pull Request #160486 · python/cpython

Conversation

@jelle-openai

@jelle-openai jelle-openai commented Oct 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Clearing an Unpickler memo left its sequential index and sparse entries intact, so reusing the unpickler for an independent record could raise UnpicklingError or retrieve an object from a previous record. Replace the memo and reset all of its state before releasing the old entries. Backport to 3.15; manually backport only the counter reset to 3.14, which has no sparse memo.
(cherry picked from commit cc36604)

Co-authored-by: Jelle Zijlstra [email protected]

Backport of #160173 to 3.14.

Reset the sequential memo index when clearing the unpickler's memo. Python 3.14 stores all memo entries in an array, so only the counter reset is needed here.

Ran test_pickle on a free-threaded 3.14 build, including clearing and reusing the unpickler for a second record.

  • Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jelle-openai
[3.14] pythongh-159739: Fully clear the unpickler memo (pythonGH-160173)
7b16449
Clearing an Unpickler memo left its sequential index and sparse entries intact, so reusing the unpickler for an independent record could raise UnpicklingError or retrieve an object from a previous record. Replace the memo and reset all of its state before releasing the old entries. Backport to 3.15; manually backport only the counter reset to 3.14, which has no sparse memo.
(cherry picked from commit cc36604)

Co-authored-by: Jelle Zijlstra <[email protected]>
This was referenced Oct 23, 2026
Fix minor safety issues #159739
Open
gh-159739: Fully clear the unpickler memo #160173
Merged
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review October 23, 2026 20:35
@bedevere-app bedevere-app Bot added the awaiting review label Oct 23, 2026
@JelleZijlstra
pythongh-159739: Replace the unpickler memo before releasing entries
e10aeba
@JelleZijlstra
JelleZijlstra merged commit 25dde93 into python:3.14 Oct 24, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jelle-openai @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.