GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-128883: Store ELF perf trampoline templates in read-only data (GH-160366) by pablogsal · Pull Request #160490 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Backport of #160366 to 3.15.

BOLT can change perf trampoline templates in executable sections and cause crashes. Store the ELF templates in .rodata, with the change in Python/asm_trampoline.S for this branch.

(cherry picked from commit 1ff83ad)

  • Issue: perf trampoline tests fail after BOLT optimizations #128883

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zanieb @pablogsal
[3.15] pythongh-128883: Store ELF perf trampoline templates in read-o…
78243d4
…nly data (pythonGH-160366)

CPython copies the trampoline templates into executable memory. Keep the
ELF source in .rodata so BOLT preserves its bytes and boundaries.
(cherry picked from commit 1ff83ad)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 23, 2026
This was referenced Oct 23, 2026
perf trampoline tests fail after BOLT optimizations #128883
Closed
gh-128883: Store ELF perf trampoline templates in read-only data #160366
Merged
@pablogsal
pablogsal enabled auto-merge (squash) October 23, 2026 20:09
@pablogsal
pablogsal merged commit e243e46 into python:3.15 Oct 23, 2026
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal deleted the backport-1ff83ad-3.15 branch October 23, 2026 21:01
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pablogsal @zanieb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.