GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-160121: Correct repeated calls to decompress() with max_length=0 by emmatyping · Pull Request #160517 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented Oct 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For compression.zstd, zlib, and bz2, buffer input and return empty bytes for calls to the decompress() method when max_length=0. Previously this could cause errors in ZstdDecompressor. I've made this change across the three modules because I would like to have the same behavior across modules. LZMA fixes are being worked on in #160205. I will wait to merge until after that PR is done to merge the NEWS entries.

  • Issue: ZstdDecompressor and LZMADecompressor raise on repeated decompress(b'', max_length=0) calls with output pending #160121

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmatyping
Correct repeated calls to decompress() with max_length=0
aaf331e
@emmatyping
emmatyping requested review from AA-Turner and StanFromIreland as code owners October 23, 2026 21:53
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 23, 2026
ZstdDecompressor and LZMADecompressor raise on repeated decompress(b'', max_length=0) calls with output pending #160121
Open
@emmatyping emmatyping added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 23, 2026
@emmatyping
emmatyping requested a review from gpshead October 30, 2026 18:52
gpshead
gpshead approved these changes Nov 1, 2026
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd that we allow 0 and act as yet another blind buffer, but it's be more awkward to try not to. making it behave right here is good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emmatyping reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@emmatyping @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.