GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-21872: fix lzma library decompresses data incompletely (GH-14048) by miss-islington · Pull Request #16054 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 12, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
    1. add test case with wrong behavior
    1. fix bug when max_length == -1
    1. allow b"" as valid input data for decompress_buf()
    1. when max_length >= 0, let needs_input mechanism works
  • add more asserts to test case
    (cherry picked from commit 4ffd05d)

Co-authored-by: animalize [email protected]

https://bugs.python.org/issue21872

Automerge-Triggered-By: @gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miss-islington
bpo-21872: fix lzma library decompresses data incompletely (pythonGH-…
67a71f7 
…14048)

* 1. add test case with wrong behavior
* 2. fix bug when max_length == -1
* 3. allow b"" as valid input data for decompress_buf()
* 4. when max_length >= 0, let needs_input mechanism works
* add more asserts to test case
(cherry picked from commit 4ffd05d)

Co-authored-by: animalize <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 12, 2019
@bedevere-bot bedevere-bot mentioned this pull request Sep 12, 2019
bpo-21872: fix lzma library decompresses data incompletely #14048
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Sep 12, 2019
gpshead
gpshead approved these changes Sep 12, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 12, 2019
@gpshead gpshead added 🤖 automerge sprint labels Sep 12, 2019
@miss-islington

miss-islington commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

@animalize and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 824407f into python:3.8 Sep 12, 2019
@miss-islington
miss-islington deleted the backport-4ffd05d-3.8 branch September 12, 2019 14:41
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 12, 2019
@miss-islington

miss-islington commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

@animalize and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

@animalize and @gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.