GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — gh-95723: setup InternalDocs/fractions.md by skirpichev · Pull Request #160625 · python/cpython Conversation
|
|
CC @mdickinson |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
FYI: this is mostly a copy-paste of the issue description, I suspect it's something that already approved. I did few additions:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks fine to me. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Nit: not sure what the line-length conventions should be for Markdown files. The file is currently 1 file line per paragraph. Is it worth reflowing? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Other files wrap lines close to PEP 8 limit. Though, not all. E.g.
It's just to simplify comparison with the issue description. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please do wrap, for people viewing locally in non-wrapping editors it makes life much easier. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Ok, done. Though, I suspect people will want to see rendered TeX... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@mdickinson if you’re happy, I can merge this, could you please review? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I won't be in a position to review effectively for around a week (on vacation without access to a real keyboard; phone doesn't count). I'm sure any changes I might ask for would be nitpick level, and I don't want to block this. I'm happy to do a post-merge review next week. Thanks @skirpichev for pushing this through! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm afraid I'm not familiar enough here to review properly, but I think a week's wait should be alright. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.