GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95723: setup InternalDocs/fractions.md by skirpichev · Pull Request #160625 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Oct 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This includes correctness proof of Fraction.limit_denominator by Mark Dickinson.

  • Issue: Document correctness of Fraction.limit_denominator #95723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@skirpichev
pythongh-95723: setup InternalDocs/fractions.md
abae92b
This includes correctness proof of Fraction.limit_denominator
by Mark Dickinson.
@skirpichev
skirpichev requested a review from AA-Turner as a code owner October 24, 2026 21:52
@bedevere-app bedevere-app Bot added the awaiting review label Oct 24, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2026
Document correctness of Fraction.limit_denominator #95723
Open
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Oct 24, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Oct 24, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 24, 2026
@StanFromIreland

StanFromIreland commented Oct 25, 2026

Copy link
Copy Markdown
Member

CC @mdickinson

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev
+ add reference to Khinchin's book
568cb5b
@skirpichev

skirpichev commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

FYI: this is mostly a copy-paste of the issue description, I suspect it's something that already approved.

I did few additions:

  1. reference to the Khinchin's book (I appreciate any other source)
  2. small preamble for the fractions.md
  3. last section with a reference to the formal proof.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev skirpichev added the pending The issue will be closed if no feedback is provided label Nov 2, 2026
@mdickinson

mdickinson commented Nov 3, 2026

Copy link
Copy Markdown
Member

Looks fine to me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mdickinson

mdickinson commented Nov 3, 2026

Copy link
Copy Markdown
Member

Nit: not sure what the line-length conventions should be for Markdown files. The file is currently 1 file line per paragraph. Is it worth reflowing?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev skirpichev removed the pending The issue will be closed if no feedback is provided label Nov 3, 2026
@skirpichev

skirpichev commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

not sure what the line-length conventions should be for Markdown files.

Other files wrap lines close to PEP 8 limit. Though, not all. E.g. InternalDocs/stack_protection.md.

The file is currently 1 file line per paragraph.

It's just to simplify comparison with the issue description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Nov 3, 2026

Copy link
Copy Markdown
Member

Please do wrap, for people viewing locally in non-wrapping editors it makes life much easier.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev
wrap lines
2598f89
@skirpichev

skirpichev commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Please do wrap, for people viewing locally in non-wrapping editors it makes life much easier.

Ok, done. Though, I suspect people will want to see rendered TeX...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland
StanFromIreland reviewed Nov 10, 2026
View reviewed changes
Comment thread InternalDocs/fractions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev
fix formatting
7b0f820
@skirpichev
skirpichev requested a review from StanFromIreland November 10, 2026 22:51
@StanFromIreland

StanFromIreland commented Nov 10, 2026

Copy link
Copy Markdown
Member

@mdickinson if you’re happy, I can merge this, could you please review?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mdickinson

mdickinson commented Nov 11, 2026

Copy link
Copy Markdown
Member

I won't be in a position to review effectively for around a week (on vacation without access to a real keyboard; phone doesn't count). I'm sure any changes I might ask for would be nitpick level, and I don't want to block this. I'm happy to do a post-merge review next week. Thanks @skirpichev for pushing this through!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Nov 11, 2026

Copy link
Copy Markdown
Member

I'm afraid I'm not familiar enough here to review properly, but I think a week's wait should be alright.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @StanFromIreland @mdickinson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.