GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-159963: Don't hold parent package import locks while a submodule executes (GH-159965) by miss-islington · Pull Request #160630 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 25, 2026 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Since gh-83065 (3.15.0), the first import of pkg.mod kept pkg's module
lock until pkg/mod.py had finished executing. Threads that needed only
the finished pkg stayed blocked for that long, and concurrent first
imports could raise _DeadlockError or a spurious "partially initialized
module" ImportError, or hang, with no import cycle involved.

Parent packages are now imported, or waited for if another thread is
initializing them, before the submodule's module lock is taken, so only
that lock is held while the submodule executes. The lock ordering
deadlock fixed by gh-83065 stays fixed.

importlib.import_module() now returns the partially initialized module
in a circular import split across threads, as the import statement
already did, instead of raising _DeadlockError. That was long-standing
behavior rather than part of the 3.15.0 regression.
(cherry picked from commit 7159b15)

Co-authored-by: Gregory P. Smith [email protected]

  • Issue: 3.15 regression: concurrent first imports can fail or hang without any import cycle #159963

Fixes #159963

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gpshead @miss-islington
pythongh-159963: Don't hold parent package import locks while a submo…
ec42c28
…dule executes (pythonGH-159965)

Since pythongh-83065 (3.15.0), the first import of pkg.mod kept pkg's module
lock until pkg/mod.py had finished executing.  Threads that needed only
the finished pkg stayed blocked for that long, and concurrent first
imports could raise _DeadlockError or a spurious "partially initialized
module" ImportError, or hang, with no import cycle involved.

Parent packages are now imported, or waited for if another thread is
initializing them, before the submodule's module lock is taken, so only
that lock is held while the submodule executes.  The lock ordering
deadlock fixed by pythongh-83065 stays fixed.

importlib.import_module() now returns the partially initialized module
in a circular import split across threads, as the import statement
already did, instead of raising _DeadlockError.  That was long-standing
behavior rather than part of the 3.15.0 regression.
(cherry picked from commit 7159b15)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested review from FFY00, brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners October 25, 2026 00:06
@bedevere-app bedevere-app Bot added the awaiting review label Oct 25, 2026
This was referenced Oct 25, 2026
3.15 regression: concurrent first imports can fail or hang without any import cycle #159963
Closed
gh-159963: Don't hold parent package import locks while a submodule executes #159965
Merged
@bedevere-app bedevere-app Bot added the sprint label Oct 25, 2026
@github-project-automation github-project-automation Bot added this to Sprint Oct 25, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 25, 2026
@gpshead gpshead self-assigned this Oct 25, 2026
@gpshead
gpshead enabled auto-merge (squash) October 25, 2026 00:07
@gpshead
Add a What's New in 3.15.2 entry
533de4b
@gpshead
gpshead requested a review from AA-Turner as a code owner October 25, 2026 00:27
@gpshead gpshead removed the sprint label Oct 25, 2026
@read-the-docs-community

read-the-docs-community Bot commented Oct 25, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35385520 | 📁 Comparing 533de4b against main (7159b15)

  🔍 Preview build  

161 files changed · + 1 added · ± 155 modified · - 5 deleted

+ Added

  • library/asyncio-policy.html

± Modified

  • index.html
  • license.html
  • py-modindex.html
  • builtins/exceptions.html
  • builtins/functions.html
  • builtins/stdtypes.html
  • c-api/bytes.html
  • c-api/capsule.html
  • c-api/complex.html
  • c-api/conversion.html
  • and 145 more...

- Deleted

  • deprecations/pending-removal-in-3.21.html
  • library/tkinter.dialogs.html
  • library/tkinter.fontchooser.html
  • library/tkinter.systray.html
  • whatsnew/3.16.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead
gpshead merged commit 3255d5d into python:3.15 Oct 25, 2026
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Sprint Oct 25, 2026
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 25, 2026
@miss-islington
miss-islington deleted the backport-7159b15-3.15 branch October 25, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.