GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-160688: Add tests for PyObject_CopyData() and PyBuffer_FillContiguousStrides() by Davien21 · Pull Request #160701 · python/cpython

Conversation

@Davien21

@Davien21 Davien21 commented Oct 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Adds _testlimitedcapi wrappers and tests for PyObject_CopyData() and PyBuffer_FillContiguousStrides(), which had none. Same layout as gh-158102: a new Modules/_testlimitedcapi/buffer.c and Lib/test/test_capi/test_buffer.py.

The PyObject_CopyData() tests cover C and Fortran contiguous 2-D copies in all four combinations, non-contiguous sources and destinations, multi-byte items, and the error paths. They don't cover copies between buffers of different shapes, because that path gives wrong results today; I'll open a separate issue for it.

Tested with a --with-pydebug build: ./python -m test -j4 test_capi test_buffer passes. Breaking the strided copy loop and the Fortran branch of PyBuffer_FillContiguousStrides() in Objects/abstract.c makes all three new tests fail.

  • Issue: Add C API tests for PyObject_CopyData and PyBuffer_FillContiguousStrides #160688

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Davien21
pythongh-160688: Add tests for PyObject_CopyData() and PyBuffer_FillC…
85e4186 
…ontiguousStrides()
@Davien21
Davien21 requested review from a team, AA-Turner, emmatyping, erlend-aasland and itamaro as code owners October 26, 2026 09:27
@python-cla-bot

python-cla-bot Bot commented Oct 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Oct 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 26, 2026
Add C API tests for PyObject_CopyData and PyBuffer_FillContiguousStrides #160688
Open
@bedevere-app

bedevere-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Davien21 Davien21 mentioned this pull request Nov 1, 2026
PyObject_CopyData() copies wrong data, and can corrupt memory, when source and destination shapes differ and the source is not contiguous #161081
Open
@Davien21
Add NEWS entry
557f432
@Davien21

Davien21 commented Nov 1, 2026

Copy link
Copy Markdown
Author

Opened gh-161081 for the different-shapes case mentioned above.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Davien21
Merge branch 'main' into capi-tests-buffer-copy
33b9b5a
@Davien21

Davien21 commented Nov 6, 2026

Copy link
Copy Markdown
Author

Please @encukou would you have time to look at this? It’s the test PR that led to gh-161081, which you replied on.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Davien21
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.