GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150582: Use _winapi for _pyrepl console mode and input flush by aisk · Pull Request #160758 · python/cpython

Conversation

@aisk

@aisk aisk commented Oct 27, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Replace ctypes based Windows console calls in _pyrepl #150582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk
pythongh-150582: Use _winapi for _pyrepl console mode and input flush
acc9560
@aisk
aisk requested review from ambv, lysnikolaou and pablogsal as code owners October 27, 2026 12:33
@bedevere-app bedevere-app Bot added the awaiting review label Oct 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 27, 2026
Replace ctypes based Windows console calls in _pyrepl #150582
Open
2 of 8 tasks
@aisk aisk added the skip news label Oct 27, 2026
@aisk
update tests
16268d7
@aisk

aisk commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

Hi @chris-eibl can you help review this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl
chris-eibl approved these changes Oct 28, 2026
View reviewed changes

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aisk. This LGTM. I've also done a quick local run.

To me, these three new funcs in _winapi make sense without any _pyrepl_ prefix or comment (#150582 (comment)), but I'd appreciate @zooba's sentiment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 28, 2026
@aisk

aisk commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

Thanks @aisk. This LGTM. I've also done a quick local run.

To me, these three new funcs in _winapi make sense without any _pyrepl_ prefix or comment (#150582 (comment)), but I'd appreciate @zooba's sentiment.

Sorry I just missed @zooba's comment on the original issue. And I agree with @chris-eibl because at least these three functions are generic enough to not need a prefix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aisk @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.