GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-160185: Fix CJK StreamWriter.reset() not returning to ASCII (GH-160186) by miss-islington · Pull Request #161068 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 1, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

reset() returned early when nothing was pending, so the shift-back
sequence of hz and iso2022_* was never written (regression from
gh-67436). Also fix a reference leak of the stream.write() result.
(cherry picked from commit aa4f541)

Co-authored-by: Gregory P. Smith [email protected]

  • Issue: CJK StreamWriter.reset() does not write the shift-back sequence #160185

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @miss-islington
pythongh-160185: Fix CJK StreamWriter.reset() not returning to ASCII (p…
2f8b097 
…ythonGH-160186)

reset() returned early when nothing was pending, so the shift-back
sequence of hz and iso2022_* was never written (regression from
pythongh-67436).  Also fix a reference leak of the stream.write() result.
(cherry picked from commit aa4f541)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested a review from corona10 as a code owner November 1, 2026 06:44
@bedevere-app bedevere-app Bot added the awaiting review label Nov 1, 2026
This was referenced Nov 1, 2026
CJK StreamWriter.reset() does not write the shift-back sequence #160185
Closed
gh-160185: Fix CJK StreamWriter.reset() not returning to ASCII #160186
Merged
@bedevere-app bedevere-app Bot added the sprint label Nov 1, 2026
@github-project-automation github-project-automation Bot added this to Sprint Nov 1, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Nov 1, 2026
@gpshead gpshead mentioned this pull request Nov 1, 2026
[3.14] gh-159739: Preserve CJK codec state across chunk boundaries and callbacks (GH-160400) #161070
Merged
@gpshead
Merge branch '3.14' into backport-aa4f541-3.14
f2f5b66
@gpshead
gpshead merged commit f11ed23 into python:3.14 Nov 1, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Sprint Nov 1, 2026
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 1, 2026
@sergey-miryanov sergey-miryanov mentioned this pull request Nov 1, 2026
How are PRs linked to their Issues and Backports? tsugiki/tsugiki#11
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.