GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-160669: Clarify `PyDict_Update` docs by sobolevn · Pull Request #161314 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PyDict_Merge and PyDict_Update have conflicting docs: both require .keys to exist #160669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-160669: Fix PyDict_Update docs
3376493
@sobolevn
sobolevn requested a review from encukou November 4, 2026 13:39
@sobolevn
sobolevn requested a review from ZeroIntensity as a code owner November 4, 2026 13:39
@sobolevn sobolevn added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 4, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2026
PyDict_Merge and PyDict_Update have conflicting docs: both require .keys to exist #160669
Open
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Nov 4, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Nov 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 4, 2026
@read-the-docs-community

read-the-docs-community Bot commented Nov 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35667453 | 📁 Comparing da23ca0 against main (f88565b)

  🔍 Preview build  

27 files changed · ± 27 modified

± Modified

  • builtins/stdtypes.html
  • builtins/threadsafety.html
  • c-api/dict.html
  • c-api/frame.html
  • c-api/gcsupport.html
  • c-api/gen.html
  • c-api/object.html
  • c-api/stable.html
  • c-api/typeobj.html
  • c-api/unicode.html
  • and 17 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes Nov 4, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 4, 2026
encukou
encukou reviewed Nov 4, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @encukou
Update Doc/c-api/dict.rst
77466e6 
Co-authored-by: Petr Viktorin <[email protected]>
sobolevn
sobolevn commented Nov 4, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Update Doc/c-api/dict.rst
1700709
vstinner
vstinner reviewed Nov 4, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @vstinner
Update Doc/c-api/dict.rst
438e363 
Co-authored-by: Victor Stinner <[email protected]>
sobolevn
sobolevn commented Nov 4, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Update Doc/c-api/dict.rst
14e2f90
vstinner
vstinner reviewed Nov 4, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now confused. The PR doesn't seem to change the text anymore, it just reformats it. Did I miss something?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn

sobolevn commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :)
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Nov 4, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :)

Ok. But then maybe don't call this PR "Fix PyDict_Update docs", but something more like "Clarify PyDict_Update docs" instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn and encukou reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@sobolevn sobolevn changed the title gh-160669: Fix PyDict_Update docs gh-160669: Clarify PyDict_Update docs Nov 4, 2026
sobolevn
sobolevn commented Nov 4, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Update Doc/c-api/dict.rst
5a5a392
encukou
encukou reviewed Nov 5, 2026
View reviewed changes
Comment thread Doc/c-api/dict.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @encukou
Update Doc/c-api/dict.rst
da23ca0 
Co-authored-by: Petr Viktorin <[email protected]>
encukou
encukou approved these changes Nov 5, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@methane methane methane approved these changes
@encukou encukou encukou approved these changes
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @vstinner @methane @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.