GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.14] gh-161185: Fix strict aliasing issue in Py_SETREF() macros family (GH-161186) (GH-161360) by miss-islington · Pull Request #161362 · python/cpython

Conversation

miss-islington commented Nov 4, 2026

Copy link

Copy Markdown

Contributor

gh-161185: Fix strict aliasing issue in Py_SETREF() macros family (GH-161186)

Py_SETREF(), Py_XSETREF() and Py_CLEAR() now use memcpy() to set
_tmp_old_dst/_tmp_old_op to fix a strict aliasing issue.

Py_SETREF(), Py_XSETREF() and Py_CLEAR() now also cast
_tmp_old_dst/_tmp_old_op to PyObject* when calling
Py_DECREF()/Py_XDECREF() to avoid compiler warnings with the limited
C API.

Add the _Py_TESTCEXT_NO_TYPEOF macro to undefine the _Py_TYPEOF
macro.

(cherry picked from commit f8e65ee)
(cherry picked from commit 0dc1a96)

Co-authored-by: Victor Stinner [email protected]
Co-authored-by: Nathan Goldbaum [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [3.15] pythongh-161185: Fix strict aliasing issue in Py_SETREF() macr…

23411df

…os family (pythonGH-161186) (pythonGH-161360)

pythongh-161185: Fix strict aliasing issue in Py_SETREF() macros family (pythonGH-161186)

Py_SETREF(), Py_XSETREF() and Py_CLEAR() now use memcpy() to set
_tmp_old_dst/_tmp_old_op to fix a strict aliasing issue.

Py_SETREF(), Py_XSETREF() and Py_CLEAR() now also cast
_tmp_old_dst/_tmp_old_op to PyObject* when calling
Py_DECREF()/Py_XDECREF() to avoid compiler warnings with the limited
C API.

Add the _Py_TESTCEXT_NO_TYPEOF macro to undefine the _Py_TYPEOF
macro.

(cherry picked from commit f8e65ee)
(cherry picked from commit 0dc1a96)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Nathan Goldbaum <[email protected]>

bedevere-app Bot added the awaiting review label

Nov 4, 2026

bedevere-app Bot mentioned this pull request

Nov 4, 2026

[C API] Py_CLEAR(), Py_SETREF() and Py_XSETREF() memcpy() implementation is not safe with strict aliasing #161185

Closed

bedevere-app Bot added the topic-C-API label

Nov 4, 2026

bedevere-app Bot mentioned this pull request

Nov 4, 2026

[3.15] gh-161185: Fix strict aliasing issue in Py_SETREF() macros family (#161186) #161360

Merged

vstinner merged commit adb9185 into python:3.14

Nov 4, 2026

53 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

Nov 4, 2026

miss-islington deleted the backport-0dc1a96-3.14 branch

November 4, 2026 23:45

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.