GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161390: Reject non-ctypes objects assigned to pointer contents by rajorin · Pull Request #161402 · python/cpython

Conversation

@rajorin

@rajorin rajorin commented Nov 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Assigning a non-ctypes object to ctypes pointer contents cast that object to CDataObject when isinstance() was fooled by a spoofed __class__. That crashed the interpreter.

Pointer.contents now requires a real ctypes object and raises TypeError otherwise.

#161390

  • Issue: ctypes: _Pointer.contents setter casts a __class__-spoofed value to CDataObject * #161390

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rajorin
pythongh-161390: Reject non-ctypes objects assigned to pointer contents
83c02fb
@bedevere-app bedevere-app Bot added the awaiting review label Nov 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2026
ctypes: _Pointer.contents setter casts a __class__-spoofed value to CDataObject * #161390
Open
@rajorin
pythongh-161390: Avoid an unresolved contents reference in the NEWS e…
9815024
…ntry
sobolevn
sobolevn reviewed Nov 6, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a breaking change for some valid code?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rajorin

rajorin commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

No. The isinstance check only ran when the value was not already a ctypes object, and a true result was still cast to CDataObject so its b_ptr could be used. There is no valid object for which that cast works.

A real ctypes value never took that branch. CDataObject_Check uses the real type, and instances of c_int (including a Python subclass) are subclasses of _ctypes._CData. Assigning one still goes through the same path as before:

class MyInt(ctypes.c_int):
    pass

ptr = ctypes.pointer(ctypes.c_int(1))
ptr.contents = MyInt(7)  # still accepted

The objects that pass isinstance and fail CDataObject_Check are objects whose __class__ is not their real type. Using those as a CDataObject crashed, which is the bug in the report. They now raise TypeError.

Assigning a different real ctypes type, such as c_char to a pointer to c_int, is unchanged. That was already accepted without the isinstance check.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rajorin @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.