GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161441: Fix tkinter and IDLE tests failing with new Tcl/Tk by serhiy-storchaka · Pull Request #161442 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 5, 2026

Copy link
Copy Markdown
Member
  • Generated events are not delivered to widgets whose window does not exist yet. Realize the widgets before generating events for them.
  • A named font whose name is a font description was never supported. Remove the check for it.

🤖 Generated with Claude Code

  • Issue: Adapt tkinter and IDLE tests to the upcoming Tcl/Tk releases #161441

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @claude
pythongh-161441: Fix tkinter and IDLE tests failing with new Tcl/Tk
07fd383 
* Generated events are not delivered to widgets whose window does not
  exist yet. Realize the widgets before generating events for them.
* A named font whose name is a font description was never supported.
  Remove the check for it.

Co-Authored-By: Claude Opus 5 <[email protected]>
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy as a code owner November 5, 2026 19:28
@serhiy-storchaka serhiy-storchaka added the skip news label Nov 5, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2026
Adapt tkinter and IDLE tests to the upcoming Tcl/Tk releases #161441
Open
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Nov 5, 2026
terryjreedy
terryjreedy approved these changes Nov 6, 2026
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is an anomaly in that there is no 'editmenu.py' being tested. It was added in 2016 (GH-49374) to test the new fix_x11_paste function (then in pyshell.py). I think it is too much a tkinter rather than IDLE test; it was never expanded to other menu entries (and I don't expect to do so here). I intend to sometime delete it.

The new claude-generated test_util.FixText.test_fix_x11_paste tests the tct code bound to . Quite clever, but I want to also extract at least 1 python test from here. Hence leave for now and fix it to pass on all Tks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 6, 2026
@terryjreedy

terryjreedy commented Nov 6, 2026

Copy link
Copy Markdown
Member

Failed tests (3): iOS (free-threading) test.test_io.test_bufferedio.CBufferedTypeTest.test_garbage_collection where Type in [Random, Reader, Writer].
https://github.com/python/cpython/actions/runs/42094154159/job/127479865296?pr=161442
Seem unrelated, retrying.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Merge branch 'main' into pythongh-161441-tk-tests
432dd39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.