GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-160427: Return None from TextIOWrapper.buffer when detached (GH-160802) by cmaloney · Pull Request #161450 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Nov 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

gh-154523 turned the buffer member descriptor into a getter that raises ValueError when the buffer is NULL, and the backport shipped in 3.14.9 and 3.15.1. That made hasattr(stream, "buffer") raise after detach(). Restore the old member descriptor result (None) while keeping the critical section.

(cherry picked from commit 3422197)

  • Issue: hasattr(stream, "buffer") fails with ValueError if buffer is detached #160427

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cmaloney
[3.14] pythongh-160427: Return None from TextIOWrapper.buffer when de…
7834ed0
…tached (pythonGH-160802)

pythongh-154523 turned the buffer member descriptor into a getter that raises
ValueError when the buffer is NULL, and the backport shipped in 3.14.9
and 3.15.1. That made hasattr(stream, "buffer") raise after detach().
Restore the old member descriptor result (None) while keeping the
critical section.
(cherry picked from commit 3422197)

Co-authored-by: Cody Maloney <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 5, 2026
This was referenced Nov 5, 2026
hasattr(stream, "buffer") fails with ValueError if buffer is detached #160427
Closed
gh-160427: Return None from TextIOWrapper.buffer when detached #160802
Merged
@cmaloney cmaloney self-assigned this Nov 5, 2026
@cmaloney
cmaloney merged commit 9106913 into python:3.14 Nov 5, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 5, 2026
@cmaloney
cmaloney deleted the backport-3422197-3.14 branch November 5, 2026 22:34
@GiggleSquid GiggleSquid mentioned this pull request Nov 11, 2026
python3Packages.robotframework: 7.4.2 -> 7.5.1 NixOS/nixpkgs#586468
Open
4 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@cmaloney cmaloney

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.